[Merge] ~mirespace/ubuntu/+source/smartmontools:bionic-lp1893202-overwritten-drivedb-h into ubuntu/+source/smartmontools:ubuntu/bionic-devel

[Miriam España Acebal]

Miriam España Acebal has proposed merging ~mirespace/ubuntu/+source/smartmontools:bionic-lp1893202-overwritten-drivedb-h into ubuntu/+source/smartmontools:ubuntu/bionic-devel.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
  Canonical Server Team (canonical-server)
Related bugs:
  Bug #1893202 in smartmontools (Ubuntu): "update-smart-drivedb overwrites package installed file"
  https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1893202

For more details, see:
https://code.launchpad.net/~mirespace/ubuntu/+source/smartmontools/+git/smartmontools/+merge/415702

This is same fix that the proposed one for Focal here https://code.launchpad.net/~mirespace/ubuntu/+source/smartmontools/+git/smartmontools/+merge/415701

---------------------------------------------------

Hello team,

PPA with the package (6.5+svn4324-1ubuntu0.2) is here:

https://launchpad.net/~mirespace/+archive/ubuntu/sru-smartmontools-bionic-focal-1893202

sudo add-apt-repository ppa:mirespace/sru-smartmontools-bionic-focal-1893202
sudo apt-get update

Bug's context:
The "drivedb.h" file is the smartmontools drive database file used to perform the scan actions. This file can be updated through update-smart-drivedb command, but debsums may complain about drive.h in the form of a false negative verification of the smartmontool packae being raised. In addition, if the smartmontool package is upgraded, the "drivedb.h" file is overwritten, therefore data will be lost.

The worst scenario would be that a drive model is included in a "drivedb.h" update at some point, and later the smartmontool package update downgrades the drive.h version, making smartmontools scans unavailable. It's true that it can be recovered through an update-smart-drivedb action, but the user might not be aware of it.

The fix applied here is picked up from upstream (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976696#30) available since version 7.2-1 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976696#30), therefore Ubuntu series starting at Impish and later are not affected. What this fix does is that it corrects the current shipping system of "drivedb.h", as well as avoiding an unconditional replacement of "drivedb.h".

No autopackage test are shipped.

Lintian report is OK:
W: smartmontools source: package-uses-deprecated-debhelper-compat-version 7
W: smartmontools source: build-depends-on-obsolete-package build-depends: dh-systemd (>= 1.13) => use debhelper (>= 9.20160709)
W: smartmontools source: vcs-deprecated-in-debian-infrastructure vcs-git git://anonscm.debian.org/collab-maint/smartmontools.git
W: smartmontools source: vcs-deprecated-in-debian-infrastructure vcs-browser http://anonscm.debian.org/gitweb/?p=collab-maint/smartmontools.git
W: smartmontools source: patch-file-present-but-not-mentioned-in-series 3w-sas
W: smartmontools source: patch-file-present-but-not-mentioned-in-series 60_remove-redhatism.diff
W: smartmontools source: ancient-standards-version 3.9.6 (released 2014-09-17) (current is 4.1.4)
W: smartmontools: wrong-name-for-upstream-changelog usr/share/doc/smartmontools/ChangeLog-5.0-6.0.gz
W: smartmontools: init.d-script-possible-missing-stop etc/init.d/smartmontools 0 6
N: 1 tag overridden (1 info)

I: Lintian run was successful.


SRU template was filed in the bug with the steps for reproducing, bad and good cases.

Thanks in advance for your time in reviewing this.
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~mirespace/ubuntu/+source/smartmontools:bionic-lp1893202-overwritten-drivedb-h into ubuntu/+source/smartmontools:ubuntu/bionic-devel.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1939 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20220216/60819f9d/attachment.diff>