[Merge] ~seb128/update-notifier:requires-livepatch-desktop into update-notifier:master

Sebastien Bacher mp+416020 at code.launchpad.net
Fri Feb 25 14:30:42 UTC 2022



Diff comments:

> diff --git a/src/ubuntu-advantage.c b/src/ubuntu-advantage.c
> index c233701..d8510ae 100644
> --- a/src/ubuntu-advantage.c
> +++ b/src/ubuntu-advantage.c
> @@ -123,6 +123,13 @@ main (int argc, char **argv)
>          return EXIT_SUCCESS;
>      }
>  
> +    // Don't display a notification if it has no use
> +    g_autoptr(GDesktopAppInfo) info = NULL;
> +    info = g_desktop_app_info_new (LIVEPATCH_DESKTOP_FILE);

Right, I just copied the style which was already in use in the same source but I wouldn't mind having those changed

> +    if (!info) {
> +        return EXIT_SUCCESS;
> +    }
> +
>      // Check if already attached.
>      gboolean attached;
>      if (!get_ubuntu_advantage_attached (&attached)) {


-- 
https://code.launchpad.net/~seb128/update-notifier/+git/update-notifier/+merge/416020
Your team Ubuntu Core Development Team is subscribed to branch update-notifier:master.




More information about the Ubuntu-reviews mailing list