[Merge] ~ubuntustudio-dev/ubiquity:main into ubiquity:main
Erich Eickmeyer
mp+449054 at code.launchpad.net
Sun Aug 13 02:34:18 UTC 2023
Erich Eickmeyer has proposed merging ~ubuntustudio-dev/ubiquity:main into ubiquity:main.
Commit message:
Allow GTK version to show on KDE Plasma Desktop
Requested reviews:
Ubuntu Installer Team (ubuntu-installer)
For more details, see:
https://code.launchpad.net/~ubuntustudio-dev/ubiquity/+git/ubiquity/+merge/449054
Ubuntu Studio intends to use the GTK version of Ubiquity for 23.10 if the ubuntu-desktop-installer customization cannot be done in time. This eliminates the line 'NotShownIn=KDE' from the icons so that it can be launched from the desktop or launcher menu.
Since Ubuntu Studio installs numerous GTK libraries, this has very little, if any, bearing on .iso image size and the GTK version of the default theme (Materia) blends quite nicely into the default experience. Additionally, the Qt version of Ubiquity is hard-coded to be for Kubuntu only, and making that part customizable would be much more tedious and require Kubuntu to create a custom configuration for Ubiquity where they haven't before.
Simply removing two lines of code from the .desktop.in files versus having to refactor numerous lines of the Qt interface and possibly inconvenience Kubuntu seems like an easier task to accommodate Ubuntu Studio. Additionally, this shouldn't affect the GTK-based desktops at all.
--
Your team Ubuntu Studio Development is subscribed to branch ~ubuntustudio-dev/ubiquity:main.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 794 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20230813/7aabfc41/attachment.diff>
More information about the Ubuntu-reviews
mailing list