[Merge] ~danilogondolfo/network-manager/+git/network-manager:fix_autopkgtests_1.44 into network-manager:ubuntu/master

[Danilo Egea Gondolfo]

Diff comments:

> diff --git a/debian/tests/nm.py b/debian/tests/nm.py
> index 2e59104..1eff335 100755
> --- a/debian/tests/nm.py
> +++ b/debian/tests/nm.py
> @@ -1014,19 +1015,17 @@ class Hotplug(NetworkManagerTest):
>      """In these tests APs are set up while NM is already running"""
>  
>      @network_test_base.run_in_subprocess
> -    @unittest.expectedFailure

I'm not completely sure why these tests were annotated with "expectedFailure". They were added like this originally. Maybe they were supposed to work but didn't at the time... some change in behavior in network manager made they work.

>      def test_auto_detect_ap(self):
>          """new AP is being detected automatically within 30s"""
>  
> -        self.setup_ap("hw_mode=b\nchannel=1\nssid=" + SSID, None)
>          self.start_nm()
> +        self.setup_ap("hw_mode=b\nchannel=1\nssid=" + SSID, None)
>          ap = self.wait_ap(timeout=300)
>          # get_ssid returns a byte array
> -        self.assertEqual(ap.get_ssid(), SSID.encode())
> +        self.assertEqual(ap.get_ssid().get_data(), SSID.encode())
>          self.assertEqual(self.nmdev_w.get_active_access_point(), None)
>  
>      @network_test_base.run_in_subprocess
> -    @unittest.expectedFailure
>      def test_auto_detect_eth(self):
>          """new eth router is being detected automatically within 30s"""
>  


-- 
https://code.launchpad.net/~danilogondolfo/network-manager/+git/network-manager/+merge/450220
Your team Network-manager is requested to review the proposed merge of ~danilogondolfo/network-manager/+git/network-manager:fix_autopkgtests_1.44 into network-manager:ubuntu/master.