[Merge] ~lamoura/update-notifier:bionic-fix-translations-on-script into update-notifier:bionic

[Andreas Hasenack]

Review: Needs Information



Diff comments:

> diff --git a/debian/control b/debian/control
> index 141ff64..bf0ae72 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -4,6 +4,7 @@ Priority: optional
>  Maintainer: Michael Vogt <michael.vogt at ubuntu.com>
>  Build-Depends: debhelper (>= 7.0.50~),
>                 dh-python,
> +               dh-autoreconf | debhelper (>= 9.20160403~),

Where does this come from? I didn't find this build-depends in any of the later releases of update-notifier.

>                 libgtk-3-dev,
>                 libglib2.0-dev (>= 2.34),
>                 libjson-glib-dev,
> diff --git a/debian/rules b/debian/rules
> index c67232e..c9a24be 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -3,7 +3,14 @@ export CFLAGS += -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
>  export LDFLAGS += -Wl,-z,defs -Wl,-O1 -Wl,--as-needed
>  
>  %:
> -	dh $@ --with python3
> +	dh $@ --with python3 --with autoreconf
> +
> +override_dh_autoreconf:
> +	NOCONFIGURE=1 dh_autoreconf ./autogen.sh
> +
> +override_dh_auto_configure:
> +	dh_auto_configure -- --libdir=/usr/lib
>  
>  override_dh_auto_test:
>  	cd tests && python3 test_package-data-downloader.py
> +	cd tests && python3 test_motd.py

What is this change about? It's not mentioned in the changelog.

> diff --git a/tests/apt_check.py b/tests/apt_check.py
> new file mode 120000
> index 0000000..7f491b8
> --- /dev/null
> +++ b/tests/apt_check.py
> @@ -0,0 +1 @@
> +../data/apt_check.py
> \ No newline at end of file

This new file is also not mentioned in the changelog. What is being fixed here, which bug?



-- 
https://code.launchpad.net/~lamoura/update-notifier/+git/update-notifier/+merge/436157
Your team Ubuntu Core Development Team is subscribed to branch update-notifier:bionic.