[Merge] ~dbungert/livecd-rootfs:ubuntu-mini-iso into livecd-rootfs:ubuntu/master
Ćukasz Zemczak
mp+436420 at code.launchpad.net
Tue Jan 31 19:56:17 UTC 2023
Review: Needs Fixing quick review
Conceptually this feels fine, I think having a separate project is the way to go. I will need to run some test builds tomorrow to see if everything is looking, so consider this review a first-glance.
A few things that need to be checked/changed:
1) xorriso is being used, which is fine but we did not use it via livecd-rootfs before. We need to make sure it's in debian/control. Good thing xorriso is now in main.
2) debian-cd actually doesn't use the xorriso command from cd-boot-images-amd64, so we'd have to make sure that the parameters are actually correct.
I'll follow up with a more detailed review later.
--
https://code.launchpad.net/~dbungert/livecd-rootfs/+git/livecd-rootfs/+merge/436420
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
More information about the Ubuntu-reviews
mailing list