[Merge] ~medicalwei/livecd-rootfs:feat/oem-extra into livecd-rootfs:ubuntu/master

Michael Hudson-Doyle mp+444895 at code.launchpad.net
Mon Jun 19 03:08:16 UTC 2023



Diff comments:

> diff --git a/live-build/auto/config b/live-build/auto/config
> index 1e45816..8e7a072 100755
> --- a/live-build/auto/config
> +++ b/live-build/auto/config
> @@ -1547,6 +1570,22 @@ EOF
>  			rm -f config/hooks/*.binary*
>  		fi
>  		;;
> +
> +	ubuntu:oem-*)
> +		# Ensure that most things e.g. includes.chroot are copied as is
> +		for entry in /usr/share/livecd-rootfs/live-build/ubuntu-oem/${SUBPROJECT}/*; do

Yao, John is from the CPC team :-) I agree with the general idea to share as much mechanism as possible. Are you saying John that you think this could be /more/ like what you are already doing?

> +			case $entry in
> +				*hooks*)
> +					# But hooks are shared across the projects with symlinks
> +					# dereference them
> +					cp -afL $entry config/
> +					;;
> +				*)
> +					# Most places want to preserve symlinks as is
> +					cp -af $entry config/
> +					;;
> +			esac
> +		done
>  esac
>  
>  case $SUBPROJECT in


-- 
https://code.launchpad.net/~medicalwei/livecd-rootfs/+git/livecd-rootfs/+merge/444895
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~medicalwei/livecd-rootfs:feat/oem-extra into livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list