[Merge] ~gjolly/livecd-rootfs:cpc/non-cloud into livecd-rootfs:ubuntu/master

Ɓukasz Zemczak mp+445124 at code.launchpad.net
Fri Jun 23 15:34:28 UTC 2023


Review: Needs Information

In general this looks fine. But I see the moved riscv64 preinstalled server bits are now still provided by the old disk-image-uefi.binary hook, duplicating code? Is the idea to first land this and then remove the duplicated old bits? Since currently it would be confusing for new people if they want to fix some, say, nezha board issues, and they'll see 2 places where the same code is located in.
-- 
https://code.launchpad.net/~gjolly/livecd-rootfs/+git/livecd-rootfs/+merge/445124
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list