[Merge] ~toabctl/livecd-rootfs:jammy-fix-snap-validate-seed into livecd-rootfs:ubuntu/jammy

Jess Jang mp+445180 at code.launchpad.net
Wed Jun 28 20:04:19 UTC 2023


> The whole overwriting of usr/share/ seems wrong to me. The bind-mount was
> already a hack and this is one too many.
> 
> The sys is bind-mounted to match the target kernel. instead of
> backuping/overwriting files, I think it would be more sane re bind-mount the
> correct kernel features in live-build/functions:setup_mountpoint and not
> overwrite anything.

Wanted to look this one too but how does that mean we check kernel version and overwrite correct one in setup_mountpoint?

it only copies generic in the live-build/functions:setup_mountpoint :thinking_face:
-- 
https://code.launchpad.net/~toabctl/livecd-rootfs/+git/livecd-rootfs-1/+merge/445180
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/jammy.




More information about the Ubuntu-reviews mailing list