[Merge] ~nteodosio/software-properties:valid-magic-wait-event into software-properties:ubuntu/master

Sebastien Bacher mp+438313 at code.launchpad.net
Mon Mar 6 13:29:39 UTC 2023


> Since wait() blocks, interrupting that thread when the user selects the other radio button is a bit involved, as far as I know. But I'll investigate this option further.

right, that might be annoying, don't worry about it if we can go with the other option


> Do you mean something like: Once wait() returns,

> - If magic button selected, call update_state as we do now.
> - If token button selected, set a flag, and make on_radio_toggled consider that flag and call update_state if set.

> ? That seems good.

yes, something around those lines
-- 
https://code.launchpad.net/~nteodosio/software-properties/+git/software-properties/+merge/438313
Your team Ubuntu Core Development Team is subscribed to branch software-properties:ubuntu/master.




More information about the Ubuntu-reviews mailing list