[Merge] ~mfo/ubuntu/+source/cinder:lp1987663-noble into ~ubuntu-openstack-dev/ubuntu/+source/cinder:master

[Mauricio Faria de Oliveira]

Mauricio Faria de Oliveira has proposed merging ~mfo/ubuntu/+source/cinder:lp1987663-noble into ~ubuntu-openstack-dev/ubuntu/+source/cinder:master.

Requested reviews:
  Corey Bryant (corey.bryant)
Related bugs:
  Bug #1987663 in cinder (Ubuntu): "cinder-volume: "Failed to re-export volume, setting to ERROR" with "tgtadm: failed to send request hdr to tgt daemon, Transport endpoint is not connected" on service startup"
  https://bugs.launchpad.net/ubuntu/+source/cinder/+bug/1987663

For more details, see:
https://code.launchpad.net/~mfo/ubuntu/+source/cinder/+git/cinder/+merge/455467

Hi Corey,

This fixes cinder-volume.service/Wants=tgt.service for Noble.

Per your request in Mantic MR [1] it uses openstack-pkg-tools
123ubuntu2, which emits Wants= for Should-Start: as well.

Could you please review and upload to Noble?
(I can only uploads to stable releases for now.)

The changes work as expected in a test package:

    $ sudo apt build-dep -y cinder
    $ dpkg -s openstack-pkg-tools | grep Version:
    Version: 123ubuntu2

    $ dpkg-source -x cinder_23.0.0-0ubuntu2.dsc
    $ cd cinder-*
    $ DEB_BUILD_OPTIONS=nocheck dpkg-buildpackage -b -uc

    $ dpkg-deb -x ../cinder-volume_23.0.0-0ubuntu2_all.deb /tmp/cinder-volume-deb
    $ fgrep tgt.service /tmp/cinder-volume-deb/lib/systemd/system/cinder-volume.service
    After=... tgt.service ...
    Wants=... tgt.service ...

Thanks,
Mauricio

[1] https://code.launchpad.net/~mfo/ubuntu/+source/cinder/+git/cinder/+merge/454428/comments/1218839
[2] https://launchpad.net/ubuntu/+source/openstack-pkg-tools/123ubuntu2
-- 
Your team Ubuntu OpenStack uploaders is subscribed to branch ~ubuntu-openstack-dev/ubuntu/+source/cinder:master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1449 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20231110/b043f85f/attachment.diff>