[Merge] ~vorlon/livecd-rootfs:lp.2034299 into livecd-rootfs:ubuntu/master

Utkarsh Gupta mp+450731 at code.launchpad.net
Tue Sep 5 21:06:20 UTC 2023


Review: Needs Information

Super, thanks for this, Steve.

But is this a workaround? The original bug notes "One possibility is that this is a regression due to wrong behavior of losetup -P returning from the kernel before the devices are settled. If so, this must be a regression in the kernel or systemd since it doesn't line up with the change in util-linux." If this is a regression, then I don't think we should close that bug with this change, should we?

I mean, sure, we could ignored the blkid call as it's there for debugging purposes but ideally we should be looking at why this fails, right?

Either way, I am +1 on landing this for now but not sure if it's appropriate or technically correct to close the bug with this fix. :)
-- 
https://code.launchpad.net/~vorlon/livecd-rootfs/+git/livecd-rootfs/+merge/450731
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list