[Merge] ~jchittum/livecd-rootfs:focal-buildd-grub into livecd-rootfs:ubuntu/focal

[John Chittum]

John Chittum has proposed merging ~jchittum/livecd-rootfs:focal-buildd-grub into livecd-rootfs:ubuntu/focal.

Commit message:
fix: GRUB_DISTRIBUTOR and grub install rectification
    
LP: 2034253 and LP: 2027686 both deal with buildd vm images failing to
boot when removing `--removable` and the stanzas copying EFI around. We
need to remove those stanzas for launchpad builder compatibility. even
though focal and jammy weren't failing, keeping everything aligned is
important. LP: 2034253 further showed that GRUB_DISTRIBUTOR being set by
default in grub requires lsb_release, which isn't in buildd images.
That's the root of why removing the stanzas failed. Since the only image
we know of where this bug is hit with grub is buildd (because everything
else has lsb_release), rather than adding a new dependency into buildd,
or backporting grub if we don't need to, setting GRUB_DISTRIBUTOR in the
buildd hook solves the immediate issue


Requested reviews:
  Canonical Foundations Team (canonical-foundations)

For more details, see:
https://code.launchpad.net/~jchittum/livecd-rootfs/+git/livecd-rootfs/+merge/451030
-- 
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/focal.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2741 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20230908/ac340210/attachment.diff>