[Merge] ~philroche/livecd-rootfs/+git/livecd-rootfs:bugfix/minimize-manual-LP-2036198 into livecd-rootfs:ubuntu/master

Philip Roche mp+451438 at code.launchpad.net
Fri Sep 15 11:00:28 UTC 2023


Philip Roche has proposed merging ~philroche/livecd-rootfs/+git/livecd-rootfs:bugfix/minimize-manual-LP-2036198 into livecd-rootfs:ubuntu/master.

Commit message:
fix: ensure minimize-manual script uses passed in argument for all commands (LP: #2036198)

minimize-manual takes an argument of the path to the chroot but of the 3 commands that are run the argument
is only used twice and with the third hardcoding "chroot" as the path to the chroot.

Thankfully "chroot" has been the patch passed in for the current uses of minimize-manual but this
could cause issues later if that were to change.

This commit resolves the problem preventing future issues.



Requested reviews:
  Canonical Foundations Team (canonical-foundations)
Related bugs:
  Bug #2036198 in livecd-rootfs (Ubuntu): "minimize-manual script takes an argument but is not used throughout script"
  https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2036198

For more details, see:
https://code.launchpad.net/~philroche/livecd-rootfs/+git/livecd-rootfs/+merge/451438
-- 
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1132 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20230915/789c8caf/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list