[Merge] ~jchittum/livecd-rootfs:noble-cpc-sboms-everywhere into livecd-rootfs:ubuntu/noble

Utkarsh Gupta mp+472002 at code.launchpad.net
Mon Aug 26 20:56:37 UTC 2024


Review: Approve

Thanks, that looks good. Sponsored the upload -

$ dput ubuntu ../livecd-rootfs_24.04.78_source.changes                                        
Uploading livecd-rootfs using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu)
running supported-distribution: check whether the target distribution is currently supported (using distro-info)
{'allowed': ['release', 'proposed', 'backports', 'security'], 'known': ['release', 'proposed', 'updates', 'backports', 'security']}
running required-fields: check whether a field is present and non-empty in the changes file
running checksum: verify checksums before uploading
running suite-mismatch: check the target distribution for common errors
running check-debs: makes sure the upload contains a binary package
running gpg: check GnuPG signatures before the upload
Uploading livecd-rootfs_24.04.78.dsc
Uploading livecd-rootfs_24.04.78.tar.xz
Uploading livecd-rootfs_24.04.78_source.buildinfo
Uploading livecd-rootfs_24.04.78_source.changes


Diff comments:

> diff --git a/live-build/functions b/live-build/functions
> index 918bd06..bd3c889 100644
> --- a/live-build/functions
> +++ b/live-build/functions
> @@ -39,6 +39,10 @@ create_empty_disk_image() {
>  create_manifest() {
>      local chroot_root=${1}
>      local target_file=${2}
> +    local base_default_sbom_name="ubuntu-cloud-image-$(grep "VERSION_ID" $chroot_root/etc/os-release | cut --delimiter "=" --field 2 | tr -d '"')-${ARCH}-$(date +%Y%m%dT%H:%M:%S)"

oh the bash! I wish it were a bit more simple.

> +    local sbom_file_name=${3:-"${base_default_sbom_name}.spdx"}
> +    local sbom_document_name=${4:-"${base_default_sbom_name}"}
> +    local sbom_log=${sbom_document_name}.log
>      echo "create_manifest chroot_root: ${chroot_root}"
>      dpkg-query --show --admindir="${chroot_root}/var/lib/dpkg" > ${target_file}
>      echo "create_manifest call to dpkg-query finished."


-- 
https://code.launchpad.net/~jchittum/livecd-rootfs/+git/livecd-rootfs/+merge/472002
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/noble.




More information about the Ubuntu-reviews mailing list