[Merge] ~dannf/livecd-rootfs/+git/livecd-rootfs:udevadm-lock into livecd-rootfs:ubuntu/master
Michael Hudson-Doyle
mp+459549 at code.launchpad.net
Sun Jan 28 20:08:03 UTC 2024
Well this is all pretty horrifying.
Diff comments:
> diff --git a/live-build/functions b/live-build/functions
> index bdd24b7..98e8425 100644
> --- a/live-build/functions
> +++ b/live-build/functions
> @@ -63,14 +63,6 @@ mount_image() {
> backing_img="$1"
> local rootpart="$2"
>
> - # As explained in excruciating detail in LP: #2045586, "losetup
> - # -P" (a.k.a. --partscan) appears to race with udev in a way that
> - # prevents the device nodes for the partitions from being
> - # created. So instead we run losetup without -P, wait for udev to
> - # settle, then run partprobe and then settle udev again (which is
> - # probably unnecessary but at this point a bit more superstition
> - # can't hurt)
> -
> loop_device=$(losetup --show -f -v ${backing_img})
Um, you need to put the -P back here?
>
> if [ ! -b ${loop_device} ]; then
--
https://code.launchpad.net/~dannf/livecd-rootfs/+git/livecd-rootfs/+merge/459549
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
More information about the Ubuntu-reviews
mailing list