[Merge] ~rmartin013/livecd-rootfs:ubuntu/jammy into livecd-rootfs:ubuntu/jammy
Loïc Minier
mp+466187 at code.launchpad.net
Fri Jun 21 17:42:56 UTC 2024
Review: Approve
Starting in a jammy environment, with the current livecd-rootfs (2.765.41) the build commands I've shared work, but pick the generic arm64 model instead of the tegra ones.
Note that there are two livecd-rootfs SRUs pending in the approval queue already:
https://launchpad.net/ubuntu/jammy/+queue?queue_state=1&queue_text=livecd-rootfs
I've started reviewing the cherry-pick/backport.
One major difference to be aware of is that jammy's livecd-rootfs used the ubuntu-image 2.x deb, not the 3.x snap. This is fine for Ubuntu Core images, but I want to highlight we'll use this somewhat eyebrows-raising setup:
* Tegra jammy Core images: livecd-rootfs from jammy using ubuntu-image 2.x deb
* Tegra jammy preinstalled images: livecd-rootfs backport using ubuntu-image 3.x snap
(This also renders backporting 430ec27308ba7c54e77f734d0b1932122e61d9d5 irrelevant)
FYI, you've cherry-picked b6c9a4d71133a532ce8c0fe753bfb725e7d61893, but IMO you should have cherry-picked the other tegra related commits first – a239256c06f625464ee4138da97aaa2113f41882 and 9f3b345b06c58d2826cf68d3da876dc062caab01.
However, I've now (painfully) verified that all Tegra changes were included in your branch.
Except for sil2100's remark, I think this can be merged.
--
https://code.launchpad.net/~rmartin013/livecd-rootfs/+git/livecd-rootfs/+merge/466187
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/jammy.
More information about the Ubuntu-reviews
mailing list