[Merge] ~danilogondolfo/netplan/+git/ubuntu:jammy_sriov_sru into ~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu-jammy

[Lukas Märdian]

This is a preliminary review, as I didn't have time to review all the individual patches, yet. But I left a few inline comments already.

PR#454 is only included in Netplan v1.1 (in Oracular, but not in Noble, yet). So this needs a clear explanation on the SRU bug report. We usually want to ship the features/fixes top-down, so that people upgrading from older releases won't regress. This needs extra paper-work (SRU template) for https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/2020409

How do we avoid issues with phased updates this time around? https://ubuntu-archive-team.ubuntu.com/phased-updates.html

Diff comments:

> diff --git a/debian/changelog b/debian/changelog
> index 3249112..067a2ea 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,15 @@
> +netplan.io (0.107.1-3ubuntu0.22.04.2) jammy; urgency=medium
> +
> +  * debian/patches/lp1988018: VF-LAG activation
> +    Fixes the order in which SR-IOV configuration is performed and
> +    cooperates with VF-LAG activation (LP: #1988018).
> +  * debian/patches/lp2020409:
> +    Enables setting the embedded-switch mode without having to define
> +    virtual functions (LP: #2020409).

Both is the correct thing to do.. but unfortunately this also means we need the paper work (SRU template) & validation for both. So LP: #2020409 needs to updated accordingly, with a good explanation why this is not (yet) in Noble.

E.g. "This will be included in the v1.1.1 SRU, but we need it now in Jammy, due to the ProdStack incident".

> +  * debian/libnetplan0.symbols: New symbol _netplan_netdef_get_bond_mode.
> +
> + -- Danilo Egea Gondolfo <danilo.egea.gondolfo at canonical.com>  Mon, 07 Oct 2024 10:57:38 +0100
> +
>  netplan.io (0.107.1-3ubuntu0.22.04.1) jammy; urgency=medium
>  
>    * Backport netplan.io 0.107.1-3 to 22.04 (LP: #2058031):
> diff --git a/debian/libnetplan0.symbols b/debian/libnetplan0.symbols
> index 908927f..a4c5a45 100644
> --- a/debian/libnetplan0.symbols
> +++ b/debian/libnetplan0.symbols
> @@ -9,6 +9,7 @@ libnetplan.so.0.0 libnetplan0 #MINVER#
>   _netplan_iter_defs_per_devtype_next at Base 0.104
>   _netplan_nameserver_iter_free at Base 0.107
>   _netplan_nameserver_iter_next at Base 0.107
> + _netplan_netdef_get_bond_mode at Base 0.107

We want to use the exact version string here "0.107.1-3ubuntu0.22.04.2~" as that symbol didn't exist in 0.107, yet.

>   _netplan_netdef_get_critical at Base 0.105
>   _netplan_netdef_get_delay_vf_rebind at Base 0.106
>   _netplan_netdef_get_embedded_switch_mode at Base 0.106


-- 
https://code.launchpad.net/~danilogondolfo/netplan/+git/ubuntu/+merge/474659
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~danilogondolfo/netplan/+git/ubuntu:jammy_sriov_sru into ~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu-jammy.