[Merge] ~juliank/ubuntu-release-upgrader:ubuntu/noble into ubuntu-release-upgrader:ubuntu/noble

Julian Andres Klode mp+472686 at code.launchpad.net
Thu Sep 5 18:33:52 UTC 2024


As for why we have those other 2 bugs:

Please look at the start of tryMarkObsoleteForRemoval, it has the "skip running kernel" and "skip ... (in KeepInstalledSection)" parts.

That also needs to be in the check whether we need to undo a change but that is only:

                for pkg in self.get_changes():
                    if (pkg.name not in remove_candidates or
                          pkg.name in foreign_pkgs or
                          self._inRemovalDenylist(pkg.name) or
                          pkg.name == self.linux_metapackage):
                        logging.debug("package '%s' produces an unwanted removal '%s', skipping" % (pkgname, pkg.name))
                        self.restore_snapshot()
                        return False


The whole thing should arguably be restructured: All the checks we do at the start we should be doing in the controler and simply remove the packages that fail the checks from remove_candidates.

But that is quite a large patch.
-- 
https://code.launchpad.net/~juliank/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/472686
Your team Ubuntu Core Development Team is subscribed to branch ubuntu-release-upgrader:ubuntu/noble.




More information about the Ubuntu-reviews mailing list