[Merge] ~ogayot/ubuntu-seeds:oracular-nvme-cli into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:oracular

[Olivier Gayot]

Olivier Gayot has proposed merging ~ogayot/ubuntu-seeds:oracular-nvme-cli into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:oracular.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~ogayot/ubuntu-seeds/+git/ubuntu-seeds/+merge/472796

Add nvme-cli to server-live for NVMe/TCP devices discovery

When doing installations with NVMe/TCP, the installer must first be
instructed to discover NVMe/TCP block devices. This can be achieved
manually by the user using a command such as `nvme connect-all [...]`

Meanwhile, if a NBFT is available in the live installer environment, it
should be possible for the installer itself to do the discovery using a
call to `nvme connect-all --nbft`.

Having the `nvme` binary in the live enviromement makes it less awkward
for a user to run the `nvme connect-all [...]` command ; and will make
it viable for the installer to run the `nvme connct-all --nbft`

Here's the diff of germinate output; showing approximately a 1MiB increase in server-live.

https://paste.ubuntu.com/p/Wkm6hFgfT3/

-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~ogayot/ubuntu-seeds:oracular-nvme-cli into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:oracular.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 319 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20240906/380ab5aa/attachment.diff>