[Merge] ~nteodosio/update-manager:b-proerror into update-manager:ubuntu/bionic

Nathan Teodosio mp+469197 at code.launchpad.net
Tue Sep 10 09:00:25 UTC 2024


I saw that but assumed it was a flake, as none of that is code we are touching.

We could address them but it would well increase the SRU and probably
need to be reflected to all series.

I think we are better off submitting the real autopkgtest. I'll upload to PPA
and do it and report back when it's done.

Am 10/09/2024 um 08:51 schrieb mp+469197 at code.launchpad.net:
> Review: Needs Information
> 
> In fact could you check the linter? The CI is showing an error
> 
> :: FAIL: test_pyflakes_clean (__main__.TestPyflakesClean)
> :: ----------------------------------------------------------------------
> :: Traceback (most recent call last):
> ::   File "./tests/test_pyflakes.py", line 56, in test_pyflakes_clean
> ::     self.assertEqual(0, len(filtered_contents))
> :: AssertionError: 0 != 8
> ::
> :: ----------------------------------------------------------------------
> :: Ran 1 test in 0.322s
> ::
> :: FAILED (failures=1)
> :: ../UpdateManager/Dialogs.py:39: 'subprocess' imported but unused
> :: ../tests/test_backend_error.py:8: 'gettext.gettext as _' imported but
> unused :: ../tests/test_backend_error.py:11:
> 'UpdateManager.Dialogs.NoUpdatesDialog' imported but unused ::
> ../tests/test_backend_error.py:12:
> 'UpdateManager.UpdateManager.UpdateManager' imported but unused ::
> ../tests/test_backend_error.py:13:
> 'UpdateManager.UpdatesAvailable.UpdatesAvailable' imported but unused ::
> ../tests/test_update_error.py:5: 'mock' imported but unused ::
> ../tests/test_update_error.py:13: 'UpdateManager.backend.InstallBackend'
> imported but unused :: ../tests/test_update_error.py:13:
> 'UpdateManager.backend.get_backend' imported but unused Job 'linter' for
> bionic/amd64 failed with exit status 1.
> 
> is that an issue in the CI job a problem that we will hit if we upload?

-- 
https://code.launchpad.net/~nteodosio/update-manager/+git/update-manager/+merge/469197
Your team Ubuntu Core Development Team is subscribed to branch update-manager:ubuntu/bionic.




More information about the Ubuntu-reviews mailing list