[Merge] ~cpete/livecd-rootfs:kdump-tools-installed-by-default into livecd-rootfs:ubuntu/master

Steve Langasek mp+473230 at code.launchpad.net
Fri Sep 13 17:16:23 UTC 2024


Review: Needs Fixing



Diff comments:

> diff --git a/live-build/auto/config b/live-build/auto/config
> index e9d5826..2f519e4 100755
> --- a/live-build/auto/config
> +++ b/live-build/auto/config
> @@ -674,6 +674,8 @@ do_layered_desktop_image() {
>  		# fixme: this should go in seeds, not be in code here
>  		add_package minimal cloud-init
>  		add_package minimal linux-$KERNEL_FLAVOURS
> +		add_package minimal kdump-tools

Well, note the fixme two lines above about using seeds instead of hard coughing packages, I think that applies here also?

> +
>  		MINIMAL_PREFIX=minimal.
>  	fi
>  


-- 
https://code.launchpad.net/~cpete/livecd-rootfs/+git/livecd-rootfs/+merge/473230
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list