[Merge] ~cpete/livecd-rootfs:fix-naive-kdump-config-modification into livecd-rootfs:ubuntu/master

[Chris Peterson]

Chris Peterson has proposed merging ~cpete/livecd-rootfs:fix-naive-kdump-config-modification into livecd-rootfs:ubuntu/master.

Commit message:
live-{server,desktop}: USE_KDUMP=0 only live layer

kdump-tools uses ucf for config file management and naively
modifying the config file meant for the target system directly
will cause the file hash to not get updated in the ucf database.
This will then cause later modifications to fail because
"there's nothing to do". Although actually doing the modification
to the ucf database is messy. Let's just modify the file in the live
layer to get the behavior we want there.


Requested reviews:
  Canonical Foundations Team (canonical-foundations)

For more details, see:
https://code.launchpad.net/~cpete/livecd-rootfs/+git/livecd-rootfs/+merge/473411

Modify /etc/default/kdump-tools only in the live layer. 

The chroot hooks introduced to disable kdump-tools by default have the side effect blocking the ability to able to enable it later due to the config file being controlled by ucf. The intent of this hook is to ensure that kdump-tools is disabled in the live layer, not change the default in the minimal layer. Subiquity always makes a decision to enable or disable the package but requires dpkg-reconfigure to work correctly, which this hook broke. 

I built ISOs using test builds for both server [0] and desktop [1] and made sure USE_KDUMP=0 is set in the live layer for each. I also tested all combinations of installs for manual/automatic/enable/disable work as intended.


[0] https://launchpad.net/~cpete/+livefs/ubuntu/oracular/test/+build/688230

[1] https://launchpad.net/~cpete/+livefs/ubuntu/oracular/test/+build/688231
-- 
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4321 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20240918/b28c12bc/attachment.diff>