[Merge] ~mylesjp/ubuntu/+source/python-oslo.rootwrap:master into ~ubuntu-openstack-dev/ubuntu/+source/python-oslo.rootwrap:master

[Nick Rosbrook]

Review: Needs Fixing

See comments inline.

Diff comments:

> diff --git a/debian/changelog b/debian/changelog
> index f11e4b5..65ed5db 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -8,6 +8,9 @@ python-oslo.rootwrap (7.6.0+git2025070911.0cb36cd-0ubuntu1) questing; urgency=me
>    * New upstream release for OpenStack Flamingo. (LP: #2116155)
>    * d/s/options: Ignore .launchpad.yaml when generating diffs.
>    * d/control: Align (Build-)Depends with upstream.

This version of the package was already uploaded, so you need a new version and changelog entry.

> +  * d/p/skip-killfilter-python3.13.patch: Add patch to skip failing
> +    test until Python 3.13 is supported upstream.
> +  * d/series: Add skip-killfilter-python3.13.patch.
>  
>   -- Myles Penner <myles.penner at canonical.com>  Wed, 16 Jul 2025 14:36:29 -0700
>  
> diff --git a/debian/patches/skip-killfilter-python3.13.patch b/debian/patches/skip-killfilter-python3.13.patch
> new file mode 100644
> index 0000000..a34a654
> --- /dev/null
> +++ b/debian/patches/skip-killfilter-python3.13.patch
> @@ -0,0 +1,27 @@
> +Description: Skip KillFilter test on Python 3.13 due to behavior change

What's the behavior change? This sort of patch should really have a bug number to give it a paper trail.

AFAICT right now, the last upload built fine and passes autopkgtest. So, a bug explaining those details seems necessary.

> +Forwarded: not-needed
> +Author: Myles Penner <myles.penner at canonical.com>
> +Last-Update: 2025-07-29
> +Index: python-oslo.rootwrap/oslo_rootwrap/tests/test_rootwrap.py
> +===================================================================
> +--- python-oslo.rootwrap.orig/oslo_rootwrap/tests/test_rootwrap.py
> ++++ python-oslo.rootwrap/oslo_rootwrap/tests/test_rootwrap.py
> +@@ -16,8 +16,10 @@ import configparser
> + import logging
> + import logging.handlers
> + import os
> ++import sys
> + import tempfile
> + from unittest import mock
> ++import unittest
> + import uuid
> + 
> + import fixtures
> +@@ -191,6 +193,7 @@ class RootwrapTestCase(testtools.TestCas
> +         self.assertEqual('somethingelse', env.get('B'))
> +         self.assertNotIn('sleep', env.keys())
> + 
> ++    @unittest.skipIf(sys.version_info >= (3, 13), "Skipping Python 3.13")
> +     def test_KillFilter(self):
> +         if not os.path.exists("/proc/%d" % os.getpid()):
> +             self.skipTest("Test requires /proc filesystem (procfs)")


-- 
https://code.launchpad.net/~mylesjp/ubuntu/+source/python-oslo.rootwrap/+git/python-oslo.rootwrap/+merge/489877
Your team Ubuntu OpenStack uploaders is requested to review the proposed merge of ~mylesjp/ubuntu/+source/python-oslo.rootwrap:master into ~ubuntu-openstack-dev/ubuntu/+source/python-oslo.rootwrap:master.