[Merge] ~eeickmeyer/ubuntu-release-upgrader:ubuntu/noble into ubuntu-release-upgrader:ubuntu/noble

Erich Eickmeyer mp+480208 at code.launchpad.net
Wed Jan 29 17:04:11 UTC 2025


Reply to your comment in-line.

Diff comments:

> diff --git a/DistUpgrade/DistUpgradeQuirks.py b/DistUpgrade/DistUpgradeQuirks.py
> index 539b2b1..1e50854 100644
> --- a/DistUpgrade/DistUpgradeQuirks.py
> +++ b/DistUpgrade/DistUpgradeQuirks.py
> @@ -2084,3 +2085,42 @@ class DistUpgradeQuirks(object):
>                  )
>              )
>              self.controller.abort()
> +
> +    def _install_pipewire_audio_on_ubuntu_studio(self):
> +        """
> +        LP: #2078639
> +        """
> +        # This is only required for upgrades from jammy.
> +        if self.controller.fromDist != 'jammy':
> +            return
> +
> +        if (
> +            'ubuntustudio-desktop' in self.controller.cache and
> +            self.controller.cache['ubuntustudio-desktop'].is_installed
> +        ):
> +            logging.debug('Detected Ubuntu Studio, installing pipewire-audio,'
> +                          '    removing pipewire-media-session and pulseaudio'
> +                )
> +
> +            try:
> +                self.controller.cache['pipewire-audio'].mark_install(
> +                    auto_fix=False
> +                )
> +                apt.ProblemResolver(self.controller.cache).protect(
> +                    self.controller.cache['pipewire-audio']
> +                )
> +
> +                self.controller.cache['pulseaudio'].mark_delete(
> +                    auto_fix=False
> +                )
> +                apt.ProblemResolver(self.controller.cache).protect(
> +                    self.controller.cache['pulseaudio']
> +                )
> +                self.controller.cache['pulseaudio:i386'].mark_delete(

To be fair, Ubuntu Studio is only supported on amd64, but I can still make the changes.

> +                    auto_fix=False
> +                )
> +                apt.ProblemResolver(self.controller.cache).protect(
> +                    self.controller.cache['pulseaudio:i386']
> +                )
> +            except KeyError as e:
> +                logging.debug(f'Failed to install pipewire-audio: {e}')


-- 
https://code.launchpad.net/~eeickmeyer/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/480208
Your team Ubuntu Core Development Team is subscribed to branch ubuntu-release-upgrader:ubuntu/noble.




More information about the Ubuntu-reviews mailing list