[Merge] pdbq:pkg-bug-updating into pdbq:main
Renan Rodrigo
mp+482490 at code.launchpad.net
Tue Mar 18 07:48:17 UTC 2025
Review: Needs Information
Single inline comment on validation
Diff comments:
> diff --git a/pdbq/bug.py b/pdbq/bug.py
> index 04e6239..af1f51c 100644
> --- a/pdbq/bug.py
> +++ b/pdbq/bug.py
> @@ -80,10 +80,34 @@ class Bug:
> ]
>
> @cached_property
> + def comments(self) -> list[dict]:
> + for message in self._instance.messages:
> + if not message.visible:
> + continue
> + comments.append(
> + {
> + 'author': message.owner.display_name,
> + 'lp_username': message.owner.name,
> + 'content': message.content,
> + 'date_created': message.date_created,
> + 'date_last_edited': message.date_last_edited,
> + }
> + )
> + return reversed(comments)
> +
> + def add_comment(self, text: str, subject: str = None) -> bool:
> + self._instance.newMessage(content=text, subject=subject)
> + return True
> +
> + @cached_property
> def description(self) -> str:
> """The Launchpad bug report's full textual description."""
> return self._instance.description
>
> + def set_description(self, new_description: str) -> bool:
> + self._instance.description = new_description
In https://code.launchpad.net/~bryce/pdbq/+git/pdbq/+merge/482254 there was this comment by John on this being possibly validated, so we are sure the data actually changed on LP. Should we do something similar here? Same for other methods in this MP
> + return True
> +
> @cached_property
> def tags(self) -> list:
> """The list of tags applied to the Launchpad bug report."""
--
https://code.launchpad.net/~bryce/pdbq/+git/pdbq/+merge/482490
Your team Ubuntu Server Developers is requested to review the proposed merge of pdbq:pkg-bug-updating into pdbq:main.
More information about the Ubuntu-reviews
mailing list