[Merge] ~lathiat/ubuntu/+source/keystone:stable/2023.2 into ~ubuntu-openstack-dev/ubuntu/+source/keystone:stable/2023.2

[Matthew Ruffell]

Hi Trent,

The following needs to be changed:

In the debian/patches/series file, the patch has been placed at the top of the
list, likely because there was an empty line here, or quilt imported the patch
when all other patches were unapplied.

All patches get applied sequentially, and if you start messing with the order,
it can cause later patches to not apply cleanly due to the same files being
changed, or require fuzz, which can change things from what was intended.

So, always check your patch is applied as the last patch in debian/patches/series.

You can make sure "quilt push -a" pushes all patches before you "quilt import",
and "quilt top" matches what you expect it to be after "quilt push -a". Note,
when you are making these git commits, you need to make them with all patches
unapplied, with "quilt pop -a".

The following are nitpicks:

I would prefer the dep3 tags you added, i.e. Origin and Bug-Ubuntu
to be below the commit message, after the "(cherry picked..." line and before
the "---" line.

You can also delete "[PATCH]" from your Subject line.

Otherwise, your SRU template is very good.

I think you should push the jammy-yoga branch first, so we can get SRU review
before we start fixing the cloud-archive builds.

Thanks,
Matthew
-- 
https://code.launchpad.net/~lathiat/ubuntu/+source/keystone/+git/keystone/+merge/491210
Your team Ubuntu OpenStack uploaders is requested to review the proposed merge of ~lathiat/ubuntu/+source/keystone:stable/2023.2 into ~ubuntu-openstack-dev/ubuntu/+source/keystone:stable/2023.2.