[Merge] ~mwhudson/livecd-rootfs/+git/livecd-rootfs:LIVECD_ROOTFS_ROOT-fixes into livecd-rootfs:ubuntu/master
Michael Hudson-Doyle
mp+502282 at code.launchpad.net
Thu Mar 19 17:41:37 UTC 2026
Michael Hudson-Doyle has proposed merging ~mwhudson/livecd-rootfs/+git/livecd-rootfs:LIVECD_ROOTFS_ROOT-fixes into livecd-rootfs:ubuntu/master.
Commit message:
fix: bake LIVECD_ROOTFS_ROOT into config/functions
Hooks that only source config/functions (not config/common) would fail
with "LIVECD_ROOTFS_ROOT: parameter not set" when calling setup_mountpoint
or any function that transitively calls it. This affected ubuntu, ubuntu-cpc,
and buildd hooks.
Rather than adding `. config/common` to every hook, prepend the
LIVECD_ROOTFS_ROOT assignment to config/functions at config time so it is
available to all callers automatically.
Requested reviews:
Canonical Foundations Team (canonical-foundations)
For more details, see:
https://code.launchpad.net/~mwhudson/livecd-rootfs/+git/livecd-rootfs/+merge/502282
--
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 753 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20260319/1e0c755f/attachment.diff>
More information about the Ubuntu-reviews
mailing list