[Bug 522204] [NEW] euca_conf --[de]register-nodes is brittle

[Thierry Carrez]

Public bug reported:

Reviewing euca_conf code, the following bit (from euca_conf --register-nodes) seems to leave some room for failure:
if ! echo "${NODES}"|grep "${NEWNODE}"
Imagine if NODES="192.168.144.10 192.168.144.11"  and you want to add 192.168.144.1...

Also the following bit called from euca_conf --deregister-nodes:
NODES="`echo $NODES|sed \"s/${NEWNODE}//\"|tr -s ' '`"
Imagine if NODES="192.168.144.10 192.168.144.1"  and you want to remove 192.168.144.1...

** Affects: eucalyptus (Ubuntu)
     Importance: Undecided
         Status: New

** Description changed:

  Reviewing euca_conf code, the following bit (from euca_conf --register-nodes) seems to leave some room for failure:
  if ! echo "${NODES}"|grep "${NEWNODE}"
  Imagine if NODES="192.168.144.10 192.168.144.11"  and you want to add 192.168.144.1...
  
  Also the following bit called from euca_conf --deregister-nodes:
  NODES="`echo $NODES|sed \"s/${NEWNODE}//\"|tr -s ' '`"
- Imagine if NODES="192.168.144.10 192.168.144.1"  and you want to add 192.168.144.1...
+ Imagine if NODES="192.168.144.10 192.168.144.1"  and you want to remove 192.168.144.1...

-- 
euca_conf --[de]register-nodes is brittle
https://bugs.launchpad.net/bugs/522204
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to eucalyptus in ubuntu.