[Bug 1115335] [NEW] hg displays errors in pre-commit.d/20warn-problem-files

[Claudio Bley]

Public bug reported:

After running aptitude, I got a slew of these error messages for all
files inside of /etc/.hg

abort: path contains illegal component: .hg/store/data/bash__completion.d.hg/service.i
abort: path contains illegal component: .hg/store/data/bash__completion.d.hg/cabal.i
abort: path contains illegal component: .hg/store/data/bash__completion.d.hg/clisp.i
abort: path contains illegal component: .hg/store/data/bash__completion.d.hg/ipmitool.i
abort: path contains illegal component: .hg/store/data/bash__completion.d.hg/bittorrent.i
abort: path contains illegal component: .hg/store/data/bash__completion.d.hg/rcs.i
abort: path contains illegal component: .hg/store/data/bash__completion.d.hg/cvsps.i
abort: path contains illegal component: .hg/store/data/bash__completion.d.hg/mount.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/65-fonts-persian.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/_r_e_a_d_m_e.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/90-synthetic.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/10-antialias.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/45-latin.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/49-sansserif.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/65-nonlatin.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/70-no-bitmaps.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/30-metric-aliases.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/80-delicious.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/60-latin.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/30-urw-aliases.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/20-unhint-small-vera.conf.i
abort: path contains illegal component: .hg/store/data/fonts/conf.d.hg/53-monospace-lcd-filter.conf.i

Looking at /etc/etckeeper/pre-commit.d/20warn-problem-files I can see
why:

line 13: hardlinks=$(find . -type f -not -links 1 -exec hg status {} \;
| exclude_internal ) || true

For every file found, a new process is started, retrieving the status
about a single file. Afterwards, an attempt is made at filtering out all
the internal files belonging to the SCM itself.

Too bad error output is not written to stdout, so the entries are never
filtered.

I suggest to change this line to:

hardlinks=$(find . -type f -not -links 1 | exclude_internal | xargs hg
status -n ) || true

Effects:

1. does not start a new process for each file found
2. filters the files before asking Mercurial for the status
3. does not display a status prefix for each file (like it's done for git)

** Affects: etckeeper (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to etckeeper in Ubuntu.
https://bugs.launchpad.net/bugs/1115335

Title:
  hg displays errors in pre-commit.d/20warn-problem-files

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/etckeeper/+bug/1115335/+subscriptions