[Bug 1399088] Re: correct the position of the syslog Handler

[Liang Chen]

** Also affects: nova (Ubuntu)
   Importance: Undecided
       Status: New

** Also affects: cinder (Ubuntu)
   Importance: Undecided
       Status: New

** Description changed:

  [Impact]
  
-  * syslog handler doesn't have the same settings as other handlers
+  * syslog handler doesn't have the same settings as other handlers
  
  [Test Case]
  
-  * Set user_syslog to True in nova.conf, restart nova services. Logs
-    written to syslog doesn't have the same format as its own service
-    log
- 
+  * Set user_syslog to True in nova.conf, restart nova services. Logs
+    written to syslog doesn't have the same format as its own service
+    log
  
  [Regression Potential]
  
-  * none
- 
+  * none
  
  correct the position of the syslog Handler
  
  syslog Handler should be in front of the line "datefmt = CONF.log_date_format"
  Then syslog Handler can have the same settings with other handlers.
  
  openstack/common/log.py
  def _setup_logging_from_conf(project, version):
      log_root = getLogger(None).logger
      for handler in log_root.handlers:
          log_root.removeHandler(handler)
  
      logpath = _get_log_file_path()
      if logpath:
          filelog = logging.handlers.WatchedFileHandler(logpath)
          log_root.addHandler(filelog)
  
      if CONF.use_stderr:
          streamlog = ColorHandler()
          log_root.addHandler(streamlog)
  
      elif not logpath:
          # pass sys.stdout as a positional argument
          # python2.6 calls the argument strm, in 2.7 it's stream
          streamlog = logging.StreamHandler(sys.stdout)
          log_root.addHandler(streamlog)
  
      if CONF.publish_errors:
          handler = importutils.import_object(
              "oslo.messaging.notify.log_handler.PublishErrorsHandler",
              logging.ERROR)
          log_root.addHandler(handler)
  
      datefmt = CONF.log_date_format
      for handler in log_root.handlers:
          # NOTE(alaski): CONF.log_format overrides everything currently.  This
          # should be deprecated in favor of context aware formatting.
          if CONF.log_format:
              handler.setFormatter(logging.Formatter(fmt=CONF.log_format,
                                                     datefmt=datefmt))
              log_root.info('Deprecated: log_format is now deprecated and will '
                            'be removed in the next release')
          else:
              handler.setFormatter(ContextFormatter(project=project,
                                                    version=version,
                                                    datefmt=datefmt))
      if CONF.debug:
          log_root.setLevel(logging.DEBUG)
      elif CONF.verbose:
          log_root.setLevel(logging.INFO)
      else:
          log_root.setLevel(logging.WARNING)
  
      for pair in CONF.default_log_levels:
          mod, _sep, level_name = pair.partition('=')
          logger = logging.getLogger(mod)
          # NOTE(AAzza) in python2.6 Logger.setLevel doesn't convert string name
          # to integer code.
          if sys.version_info < (2, 7):
              level = logging.getLevelName(level_name)
              logger.setLevel(level)
          else:
              logger.setLevel(level_name)
  
      if CONF.use_syslog:
          try:
              facility = _find_facility_from_conf()
              # TODO(bogdando) use the format provided by RFCSysLogHandler
              #   after existing syslog format deprecation in J
              if CONF.use_syslog_rfc_format:
                  syslog = RFCSysLogHandler(address='/dev/log',
                                            facility=facility)
              else:
                  syslog = logging.handlers.SysLogHandler(address='/dev/log',
                                                          facility=facility)
              log_root.addHandler(syslog)
          except socket.error:
              log_root.error('Unable to add syslog handler. Verify that syslog '
                             'is running.')

** Description changed:

+ Nova SRU:
  [Impact]
  
   * syslog handler doesn't have the same settings as other handlers
  
  [Test Case]
  
   * Set user_syslog to True in nova.conf, restart nova services. Logs
     written to syslog doesn't have the same format as its own service
     log
  
  [Regression Potential]
  
   * none
+ 
+ Cinder SRU:
+ [Impact]
+ 
+  * syslog handler doesn't have the same settings as other handlers
+ 
+ [Test Case]
+ 
+  * Set user_syslog to True in cinder.conf, restart cinder services. Logs
+    written to syslog doesn't have the same format as its own service
+    log
+ 
+ [Regression Potential]
+ 
+  * none
+ 
  
  correct the position of the syslog Handler
  
  syslog Handler should be in front of the line "datefmt = CONF.log_date_format"
  Then syslog Handler can have the same settings with other handlers.
  
  openstack/common/log.py
  def _setup_logging_from_conf(project, version):
      log_root = getLogger(None).logger
      for handler in log_root.handlers:
          log_root.removeHandler(handler)
  
      logpath = _get_log_file_path()
      if logpath:
          filelog = logging.handlers.WatchedFileHandler(logpath)
          log_root.addHandler(filelog)
  
      if CONF.use_stderr:
          streamlog = ColorHandler()
          log_root.addHandler(streamlog)
  
      elif not logpath:
          # pass sys.stdout as a positional argument
          # python2.6 calls the argument strm, in 2.7 it's stream
          streamlog = logging.StreamHandler(sys.stdout)
          log_root.addHandler(streamlog)
  
      if CONF.publish_errors:
          handler = importutils.import_object(
              "oslo.messaging.notify.log_handler.PublishErrorsHandler",
              logging.ERROR)
          log_root.addHandler(handler)
  
      datefmt = CONF.log_date_format
      for handler in log_root.handlers:
          # NOTE(alaski): CONF.log_format overrides everything currently.  This
          # should be deprecated in favor of context aware formatting.
          if CONF.log_format:
              handler.setFormatter(logging.Formatter(fmt=CONF.log_format,
                                                     datefmt=datefmt))
              log_root.info('Deprecated: log_format is now deprecated and will '
                            'be removed in the next release')
          else:
              handler.setFormatter(ContextFormatter(project=project,
                                                    version=version,
                                                    datefmt=datefmt))
      if CONF.debug:
          log_root.setLevel(logging.DEBUG)
      elif CONF.verbose:
          log_root.setLevel(logging.INFO)
      else:
          log_root.setLevel(logging.WARNING)
  
      for pair in CONF.default_log_levels:
          mod, _sep, level_name = pair.partition('=')
          logger = logging.getLogger(mod)
          # NOTE(AAzza) in python2.6 Logger.setLevel doesn't convert string name
          # to integer code.
          if sys.version_info < (2, 7):
              level = logging.getLevelName(level_name)
              logger.setLevel(level)
          else:
              logger.setLevel(level_name)
  
      if CONF.use_syslog:
          try:
              facility = _find_facility_from_conf()
              # TODO(bogdando) use the format provided by RFCSysLogHandler
              #   after existing syslog format deprecation in J
              if CONF.use_syslog_rfc_format:
                  syslog = RFCSysLogHandler(address='/dev/log',
                                            facility=facility)
              else:
                  syslog = logging.handlers.SysLogHandler(address='/dev/log',
                                                          facility=facility)
              log_root.addHandler(syslog)
          except socket.error:
              log_root.error('Unable to add syslog handler. Verify that syslog '
                             'is running.')

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to nova in Ubuntu.
https://bugs.launchpad.net/bugs/1399088

Title:
  correct the position of the syslog Handler

To manage notifications about this bug go to:
https://bugs.launchpad.net/oslo-incubator/+bug/1399088/+subscriptions