[Bug 1448205] Re: Crash when removing <filterref> from interface with update-device

[Serge Hallyn]

** Description changed:

+ ===================================================
+ SRU Justification
+ 1. Impact: crash when removing filterref from a network interface
+ 2. Test case: Create an interface with filterref (see below), then update it and try to remove it.
+ 3. Regression potential: the patch simply avoids attempting to instantiate a filter if the filter has been removed.  There should be no regressions.
+ ===================================================
+ 
  Hello,
  
  We're running into this issue on our 14.04 LTS hosts, when removing all
  filterref's on an interface, it results in a crash.
  
  # virsh dump-xml e7276b62-887f-443e-b85b-ea3b5c395924
  .....
  <interface type='bridge'>
-   <mac address='fa:16:3e:1c:cf:99'/>
-   <source bridge='qbr3f490a54-72'/>
-   <target dev='tap3f490a54-72'/>
-   <model type='virtio'/>
-   <filterref filter='illuminate-smtp-block'/>
-   <alias name='net0'/>
-   <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
+   <mac address='fa:16:3e:1c:cf:99'/>
+   <source bridge='qbr3f490a54-72'/>
+   <target dev='tap3f490a54-72'/>
+   <model type='virtio'/>
+   <filterref filter='illuminate-smtp-block'/>
+   <alias name='net0'/>
+   <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
  </interface>
  ....
  
  Update attempt
- # cat interface.xml 
+ # cat interface.xml
  <interface type="bridge">
-   <mac address="fa:16:3e:1c:cf:99"/>
-   <source bridge="qbr3f490a54-72"/>
-   <target dev="tap3f490a54-72"/>
-   <model type="virtio"/>
-   <alias name="net0"/>
-   <address type="pci" domain="0x0000" bus="0x00" slot="0x03" function="0x0"/>
+   <mac address="fa:16:3e:1c:cf:99"/>
+   <source bridge="qbr3f490a54-72"/>
+   <target dev="tap3f490a54-72"/>
+   <model type="virtio"/>
+   <alias name="net0"/>
+   <address type="pci" domain="0x0000" bus="0x00" slot="0x03" function="0x0"/>
  </interface>
  # virsh update-device e7276b62-887f-443e-b85b-ea3b5c395924 interface.xml
  .. libvirtd segfaults!
  
  There is an existing patch for this which addresses this issue, but it
  seems that it's not backported into current sources.
  
  http://www.redhat.com/archives/libvir-list/2014-May/msg00005.html

** No longer affects: libvirt (Ubuntu Utopic)

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to libvirt in Ubuntu.
https://bugs.launchpad.net/bugs/1448205

Title:
  Crash when removing <filterref> from    interface with update-device

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1448205/+subscriptions