[Bug 1504354] Re: Invalid memory access on ap_server_config_defines

[Bug Watch Updater]

Launchpad has imported 4 comments from the remote bug at
https://bz.apache.org/bugzilla/show_bug.cgi?id=57328.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2014-12-08T11:16:20+00:00 A-abfalterer wrote:

Created attachment 32268
Patch to dump elements of ap_server_config_defines after a graceful restart, includes also fix for the problem

== Reproduction ==

1) Find attached a patch for server/core.c that dumps the elements of
ap_server_config_defines after a graceful restart.

2) Define some variables in httpd.conf, e.g.

Define arg1=val1
Define arg2=val2
Define arg3=val4

3) By doing some graceful restarts (5-10 times), the increasing number
of array elements with invalid memory references can be observerd. The
problem can be reproduced each time.

== Explanation ==

After a graceful restart, the reset_config_defines() function in
server/core.c resets ap_server_config_defines back to its original
pointer saved_server_config_defines. Henceforth, variable definitions
(by means of Define) are stored in the original array, and thus, leading
to invalid memory access upon next graceful restarts.

== Solution == 
A fix to the problem can be found in the provided patch file and be enabled by setting the macro constant WITH_FIX to 1.

Regards, Armin

Reply at:
https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1504354/comments/0

------------------------------------------------------------------------
On 2014-12-08T14:35:43+00:00 Ylavic-dev wrote:

Committed in r1643825.

I first misread your patch and started working on a much more
complicated one, until I realized yours was the minimal/only change
needed.

Thanks for the analysis and patch Armin, will propose it for 2.4.x.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1504354/comments/1

------------------------------------------------------------------------
On 2014-12-08T14:39:06+00:00 Ylavic-dev wrote:

*** Bug 56008 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1504354/comments/2

------------------------------------------------------------------------
On 2015-01-23T08:10:03+00:00 Ylavic-dev wrote:

Backported to 2.4.11 (unreleased) in r1651083, available in upcoming
2.4.12.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1504354/comments/3


** Changed in: apache2
       Status: Unknown => Fix Released

** Changed in: apache2
   Importance: Unknown => Critical

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to apache2 in Ubuntu.
https://bugs.launchpad.net/bugs/1504354

Title:
  Invalid memory access on ap_server_config_defines

To manage notifications about this bug go to:
https://bugs.launchpad.net/apache2/+bug/1504354/+subscriptions