[Bug 1487010] Re: please upload new package to reenable go's race detector on wily

Martin Pitt martin.pitt at ubuntu.com
Fri Sep 18 05:52:56 UTC 2015


Packaging review:
 - Please use 3.0 (quilt) source format for clean and standard patch management.

 - Disabling "make check" (override_dh_auto_test) is a bit sad -- when
running "make check" it fails with "unable to infer compiler target
triple for clang". Is there any way to run the tests with gcc? If not,
should this get a clang build dependency? If that doesn't work, please
add a comment to debian/rules why tests can't/shouldn't be run.

 - W: go-race-detector-runtime source: dep5-copyright-license-name-not-unique (paragraph at line 35)
   Indeed you used "License: Expat" with two different license texts, AFAICS mostly due to including the copyright into it (which shouldn't happen -- that's what Copyright: is for). It's usually best to just say "License: Expat" in all Files: stanzas, and have a separate

  License: expat
    ..blabla long text

  stanza at the bottom, to avoid repetition.

 - There are several missing copyrights in debian/copyright, e. g.
./lib/BlocksRuntime/Block.h has "Copyright 2008-2010 Apple, Inc." and
the license is BSD.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to golang in Ubuntu.
https://bugs.launchpad.net/bugs/1487010

Title:
  please upload new package to reenable go's race detector on wily

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/golang/+bug/1487010/+subscriptions



More information about the Ubuntu-server-bugs mailing list