[Bug 1859685] Re: google-cloud-print-connector FTBFS (focal)

[Rafael David Tinoco]

Christian,

Thanks a lot for reviewing this. And, yes, +1 on everything you said
about ugly/effective. I thought that had less chances to introduce a bug
then changing the functions to new CUPS functions (which I would have
tried with upstream if better maintained).

Thanks! Uploading it...

** Description changed:

+ [Impact]
+ 
+  * google-cloud-print-connector FTBFS in Focal because of recent CUPS
+ version being used in that Ubuntu version (2.3.0-7ubuntu1)
+ 
+ [Test Case]
+ 
+  * dpkg-buildpackage -b -us -uc in google-cloud-print-connector source
+ package directory.
+ 
+ [Regression Potential]
+ 
+  * There are 2 ways to fix the issue:
+ 
+    1) allow print-connector to keep accessing IPP internal structures,
+ like it was before, disconsidering the fact that recent CUPS might not
+ like it (since it removed the feature, not it may consider they're
+ dynamic and not accessible externally).
+ 
+    2) fix print-connector by changing internal (to IPP) data structure
+ access (IPP status, basically) for the CUPS functions that make internal
+ structures data available.
+ 
+ (1) is faster and safer for now, specially considering the fact that
+ this package might be EOL soon. chances of regression are reduced if
+ using (1) to fix FTBFS.
+ 
+ [Other Info]
+  
+ ORIGINAL DESCRIPTION:
+ 
  While trying to generate binary package for google-cloud-print-
  connector, we get:
  
  github.com/coreos/go-systemd/journal
  github.com/google/cloud-print-connector/log
  github.com/google/cloud-print-connector/cups
  # github.com/google/cloud-print-connector/cups
  cgo-gcc-prolog: In function ‘_cgo_033c9b726dd2_Cfunc_cupsGetPPD3’:
  cgo-gcc-prolog:95:2: warning: ‘cupsGetPPD3’ is deprecated: Use cupsCopyDestInfo and friends instead. [-Wdeprecated-declarations]
  In file included from src/github.com/google/cloud-print-connector/cups/cups.h:15,
-                  from src/github.com/google/cloud-print-connector/cups/core.go:14:
+                  from src/github.com/google/cloud-print-connector/cups/core.go:14:
  /usr/include/cups/ppd.h:360:22: note: declared here
-   360 | extern http_status_t cupsGetPPD3(http_t *http, const char *name, time_t *modtime, char *buffer, size_t bufsize) _CUPS_DEPRECATED_1_6_MSG("Use cupsCopyDestInfo and friends instead.");
-       |                      ^~~~~~~~~~~
+   360 | extern http_status_t cupsGetPPD3(http_t *http, const char *name, time_t *modtime, char *buffer, size_t bufsize) _CUPS_DEPRECATED_1_6_MSG("Use cupsCopyDestInfo and friends instead.");
+       |                      ^~~~~~~~~~~
  # github.com/google/cloud-print-connector/cups
  cups.c: In function ‘getIPPRequestStatusCode’:
  cups.c:42:12: error: dereferencing pointer to incomplete type ‘ipp_t’ {aka ‘struct _ipp_s’}
-    42 |  return ipp->request.status.status_code;
-       |            ^~
+    42 |  return ipp->request.status.status_code;
+       |            ^~
  cups.c: In function ‘getAttributeDateValue’:
  cups.c:47:13: error: dereferencing pointer to incomplete type ‘ipp_attribute_t’ {aka ‘struct _ipp_attribute_s’}
-    47 |  return attr->values[i].date;
-       |             ^~
+    47 |  return attr->values[i].date;
+       |             ^~
  crypto
  crypto/internal/randutil
  bufio

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1859685

Title:
  google-cloud-print-connector FTBFS (focal)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/golang-codegangsta-cli/+bug/1859685/+subscriptions