[Bug 1923145] Re: Actually support Ubuntu

[Dan Streetman]

I adjusted the patch slightly to match the upstream commit, and uploaded
to f/g/h.

Thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1923145

Title:
  Actually support Ubuntu

Status in mkosi package in Ubuntu:
  In Progress
Status in mkosi source package in Bionic:
  New
Status in mkosi source package in Focal:
  New
Status in mkosi source package in Groovy:
  New
Status in mkosi source package in Hirsute:
  In Progress

Bug description:
  [impact]

  mkosi does not work on ubuntu when using distribution detection
  instead of specifying distribution and release codename

  [test case]

  see original description

  [regression potential]

  any regression would likely result in immediate failure on ubuntu
  and/or when running mkosi for ubuntu

  [scope]

  this is needed for f,g,h

  this was fixed upstream by commit
  743a06b0afd1215c4a63e7f30d8f10a128d07293 which was first included in
  version 6, so this is needed in h and earlier.

  this is also needed for b, but that version is so old that it would
  require other changes

  [other info]

  debian MR:
  https://salsa.debian.org/systemd-team/mkosi/-/merge_requests/2

  [original description]

  version 5-1 does not support Ubuntu correctly in that it tries to use
  the version number rather than version codename in arguments to
  debootstrap.

  $ sudo mkosi
  ...
  Traceback (most recent call last):
    File "/usr/bin/mkosi", line 4539, in <module>
      main()
    File "/usr/bin/mkosi", line 4535, in main
      run_verb(args)
    File "/usr/bin/mkosi", line 4507, in run_verb
      build_stuff(args)
    File "/usr/bin/mkosi", line 4333, in build_stuff
      raw, tar, root_hash = build_image(args, workspace, do_run_build_script=False, cleanup=True)
    File "/usr/bin/mkosi", line 4153, in build_image
      install_distribution(args, workspace.name,
    File "/usr/bin/mkosi", line 1987, in install_distribution
      install[args.distribution](args, workspace, do_run_build_script)
    File "/usr/lib/python3.8/contextlib.py", line 75, in inner
      return func(*args, **kwds)
    File "/usr/bin/mkosi", line 1717, in install_ubuntu
      install_debian_or_ubuntu(args, workspace, do_run_build_script=do_run_build_script, mirror=args.mirror)
    File "/usr/bin/mkosi", line 1633, in install_debian_or_ubuntu
      run(cmdline, check=True)
    File "/usr/bin/mkosi", line 69, in run
      return subprocess.run(cmdline, **kwargs)
    File "/usr/lib/python3.8/subprocess.py", line 512, in run
      raise CalledProcessError(retcode, process.args,
  subprocess.CalledProcessError: Command '['debootstrap', '--verbose', '--variant=minbase', '--include=systemd-sysv', '--exclude=sys
  v-rc,initscripts,startpar,lsb-base,insserv', '--components=main', '--merged-usr', '"20.04"', '/var/tmp/mkosi-akzr5g4y/root', 'http
  ://archive.ubuntu.com/ubuntu']' returned non-zero exit status 1.

  Notice the "20.04" argument passed to debootstrap, which should be
  "focal".

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mkosi/+bug/1923145/+subscriptions