[Bug 1953572] Re: Broken links in the View Trends and the View Histogram menu

[Lena Voytek]

Hi Jorge and Mauricio, I will sponsor for oracular. The change looks
good to me overall, I just have a few notes:

Since the changes to the THANKS and Changelog files are not relevant to
the build, and the patch is already a backport due to line number
changes, I would recommend removing those portions for better patch
compatibility with future updates.

Mauricio also already mentioned changing Origin: upstream to Origin:
backport. I can change that too

Last minor note - in the changelog for the lp bug number I'd recommend
surrounding with parenthesis for formatting - (LP: #1953572). I've seen
some of our automation miss bug numbers in the past without them.

If you would like I can update the debdiff and sponsor, thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1953572

Title:
  Broken links in the View Trends and the View Histogram menu

Status in nagios4 package in Ubuntu:
  In Progress
Status in nagios4 source package in Focal:
  In Progress
Status in nagios4 source package in Jammy:
  In Progress
Status in nagios4 source package in Mantic:
  Won't Fix
Status in nagios4 source package in Noble:
  In Progress
Status in nagios4 source package in Oracular:
  In Progress

Bug description:
  [Impact]
  The links for the following are broken in the Service Information or the Host Information menus for the following links:

  View Trends For This Service
  View Alert Histogram For This Service
  View Trends For This Host
  View Alert Histogram For This Host

  [Test Plan]
  See deployment steps in comment #15.
  Just access those links in: Current status / Hosts and Current status / Services and choosing a host or a service
  Test all other links following the menu/pages for no broken links / regressions.

  [Where problems could occur]
  The URLs for the affected pages have been changed from relative to absolute. Nothing else has changed so this patch should not affect any other page. The worst case scenario would be that the patch has inadvertently modified the link for other pages. In any case the absolute links should also work.

  [Other Info]
  Upstream code has been patched to fix a bug that required that the html files (on /nagios4) should be one folder level below cgi-bin. This was because sometimes Nagios tried to reach html files as ../file.html while the base url was pointing to the cgi-bin folder. This relative URLs where substituted for absolute URLs. The deb package sets the cgi url to /cgi-bin/nagios4 so was affected by this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nagios4/+bug/1953572/+subscriptions