[Bug 2052294] Re: Please merge 0.7.3-6.4 into noble

[Nick Rosbrook]

Thanks for the debdiffs, Ravi. A few comments below:

(1) In the changelog, you have:

- Include cdbs' autoreconf rules to generate new Makefiles

in remaining changes. However, Debian dropped CDBS support in 0.7.3-6.2,
which obsoletes that change. Hence, there should be an entry like:

* Dropped changes, no longer needed:
  - Include cdbs' autoreconf rules to generate new Makefiles

(2) Your current diff shows a d/rules delta of:

diff -Nru ltrace-0.7.3/debian/rules ltrace-0.7.3/debian/rules
--- ltrace-0.7.3/debian/rules	2022-05-03 01:51:07.000000000 +0200
+++ ltrace-0.7.3/debian/rules	2024-02-02 13:11:39.000000000 +0100
@@ -1,5 +1,11 @@
 #!/usr/bin/make -f
 
+cdbs_configure_flags := --with-libunwind=no
+
+# The configure logic for this is backwards. We need this before checking
+# for elfutils (ELF_C_READ_MMAP)
+CFLAGS=-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
+
 %:
 	dh $@
 
@@ -8,5 +14,5 @@
 
 override_dh_install:
 	dh_install
-	rm -f debian/ltrace/usr/share/doc/ltrace/COPYING
-	rm -f debian/ltrace/usr/share/doc/ltrace/INSTALL
+	rm -f debian/ltrace/usr/share/doc/ltrace/COPYING*
+	rm -f debian/ltrace/usr/share/doc/ltrace/INSTALL*

However, with Debian's move to debhelper, the cdbs_configure_flags
change is obsolete, and I don't think that was ever our addition.
Similarly, I don't think we should have any delta in
`override_dh_install` (the asterisks were Debian's too, not our delta).

Therefore, I believe our only delta in d/rules should be the
CFLAGS=-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE bit (though this may be
outdated, bonus points if you check that this is still needed).

** Changed in: ltrace (Ubuntu)
       Status: New => Incomplete

** Changed in: ltrace (Ubuntu)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2052294

Title:
  Please merge 0.7.3-6.4 into noble

Status in ltrace package in Ubuntu:
  Incomplete

Bug description:
  tracking bug

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ltrace/+bug/2052294/+subscriptions