[Bug 2048923] Re: [SRU] r8168-dkms fails to build module on kernel 6.5.0-14-generic

[Julian Andres Klode]

Sponsored, thank you.

** Changed in: r8168 (Ubuntu Jammy)
       Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2048923

Title:
  [SRU] r8168-dkms fails to build module on kernel 6.5.0-14-generic

Status in r8168 package in Ubuntu:
  Fix Released
Status in r8168 source package in Jammy:
  In Progress

Bug description:
  [ Impact ]

  r8168-dkms fails to install if the user is using the hwe kernel which is v6.5 as the dkms module will fail to build during installation.
  The error being:

  /usr/src/r8168-8.049.02/r8168_n.c: In function ‘r8168_csum_workaround’:
  /usr/src/r8168-8.049.02/r8168_n.c:27733:24: error: implicit declaration of function ‘skb_gso_segment’; did you mean ‘skb_gso_reset’? [-Werror=implicit-function-declaration]
  27733 |                 segs = skb_gso_segment(skb, features);
        |                        ^~~~~~~~~~~~~~~

  
  [ Test Plan ]

  This needs to be done on both the hwe kernel (v6.5) and the generic
  kernel (v5.15) to ensure it works on both.

  * install r8168-dkms
  * successfull installation will mean the build failure has been fixed.
  * As a very basic test, try to load the module "sudo modprobe r8168"

  Ideally someone with the hardware should test and confirm.

  [ Where problems could occur ]

  This change is only affecting the users of hwe kernel (v6.5) and the
  only change is adding a header file which declare the function its
  trying to use. Similar changes has been done to other upstream network
  drivers as can be seen at the upstream kernel patch link and has
  little chance of regression due to this.

  [ Other Info ]

   * The change in the upstream linux kernel has been done via:
  https://lore.kernel.org/all/20230608191738.3947077-1-edumazet@google.com/

  [ Original Bug Description ]

  After recent upgrade to kernel 6.5.0-14-generic my ethernet connection
  no longer works, because dkms is unable to compile module for this
  kernel. I'm on kubuntu lts 22.04.3. On all the previous kernels this
  worked fine.

  $ lsb_release -rd
  Description:    Ubuntu 22.04.3 LTS
  Release:        22.04

  $ apt-cache policy r8168-dkms
  r8168-dkms:
    Instalovaná verze: 8.049.02-1ubuntu1.2
    Kandidát:          8.049.02-1ubuntu1.2
    Tabulka verzí:
   *** 8.049.02-1ubuntu1.2 500
          500 https://mirror.dkm.cz/ubuntu jammy-updates/universe amd64 Packages
          500 https://mirror.dkm.cz/ubuntu jammy-updates/universe i386 Packages
          100 /var/lib/dpkg/status
       8.049.02-1ubuntu1 500
          500 https://mirror.dkm.cz/ubuntu jammy/universe amd64 Packages
          500 https://mirror.dkm.cz/ubuntu jammy/universe i386 Packages

  Expected behavior: dkms successfully builds the r8168 module when new
  kernel is installed and the ethernet connection works.

  What happened instead: dkms failed to build the r8168 module for the
  new 6.5.0-14-generic kernel and the ethernet connection no longer
  works.

  Please see attached crash log from dkms.

  ProblemType: Bug
  DistroRelease: Ubuntu 22.04
  Package: r8168-dkms 8.049.02-1ubuntu1.2
  ProcVersionSignature: Ubuntu 6.2.0-39.40~22.04.1-generic 6.2.16
  Uname: Linux 6.2.0-39-generic x86_64
  NonfreeKernelModules: nvidia_modeset nvidia
  ApportVersion: 2.20.11-0ubuntu82.5
  Architecture: amd64
  CasperMD5CheckResult: unknown
  CurrentDesktop: KDE
  Date: Wed Jan 10 18:56:53 2024
  InstallationDate: Installed on 2021-05-13 (972 days ago)
  InstallationMedia: Kubuntu 20.04.2.0 LTS "Focal Fossa" - Release amd64 (20210209.1)
  PackageArchitecture: all
  SourcePackage: r8168
  UpgradeStatus: Upgraded to jammy on 2022-08-15 (513 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/r8168/+bug/2048923/+subscriptions