[Bug 2065051] Re: [SRU] Migrate Pi users to KMS

[Dave Jones]

Verified with upgrade of a Pi 4 on an SD card as described in the test
plan, only variant being to grab the noble tar-ball manually (as do-
release-upgrade won't allow --proposed with --devel). Worked happily,
KMS was present in the config.txt after the upgrade, and the HDMI audio
outputs appeared correctly when the card was subsequently booted on a Pi
5.

** Tags removed: verification-needed-noble
** Tags added: verification-done-noble

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2065051

Title:
  [SRU] Migrate Pi users to KMS

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Committed
Status in ubuntu-release-upgrader source package in Noble:
  Fix Committed

Bug description:
  [ Impact ]

  In switching Pi Server users over to the KMS overlay (as resolution to
  LP: #2038924) we need an additional quirk for upgraders to migrate
  config.txt (this will be similar, but not identical, to the one for
  LP: #1923673).

  If we do not migrate such users, the immediate impact is that Pi 5
  users will have no sound output on server images (the Pi 5 only has
  HDMI audio output, no auxiliary jack). Potentially more problematic in
  the long-run, though, is that we will wind up with users on different
  graphical stacks (the KMS stack, which is the only upstream supported
  stack going forward, and the legacy framebuffer method).

  [ Test Case ]

  * Flash Ubuntu jammy to SD card and boot on Pi 4
  * Check /boot/firmware/config.txt does not contain dtoverlay=vc4-kms-v3d (it should not on Pi server images)
  * sudo do-release-upgrade
  * Proceed through upgrade and reboot
  * Ensure system reboots successfully
  * After reboot, check /boot/firmware/config.txt contains dtoverlay=vc4-kms-v3d
  * Shutdown, move SD card to Pi 5 and boot it
  * Check /proc/asound/cards contains entries for vc4hdmi

  [ Regression Potential ]

  The use of the KMS overlay itself is not concerning; we already use it
  on the Pi desktop images, and have for several cycles now with no
  serious issues, so the regression potential there is minimal.

  However, the quirk does manipulate the bootloader's config.txt on the
  boot partition, which always carries the potential of leaving a system
  unbootable. To guard against this, tests are included with the quirk
  which check for several scenarios including a config.txt which has
  already been migrated to the KMS overlay manually by the user (there
  are various reasons to do this, including running kmscon), as well as
  the typical expected case.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/2065051/+subscriptions