[Bug 2097808] Re: IPv6 support for iBFT iSCSI boot

[Lukas Märdian]

Thanks, LGTM.
- The patch matches the changes merged upstream.
- Proper DEP3 headers
- Builds fine on Plucky.
- Autopkgtest are broken becasue of (unrelated) bug #2095584 – but do not regress further due to this.

Sponsored into Plucky: https://launchpad.net/ubuntu/+source/open-
iscsi/2.1.10-3ubuntu2

** Changed in: open-iscsi (Ubuntu Plucky)
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2097808

Title:
  IPv6 support for iBFT iSCSI boot

Status in open-iscsi package in Ubuntu:
  Fix Committed
Status in open-iscsi source package in Focal:
  In Progress
Status in open-iscsi source package in Jammy:
  In Progress
Status in open-iscsi source package in Noble:
  In Progress
Status in open-iscsi source package in Oracular:
  In Progress
Status in open-iscsi source package in Plucky:
  Fix Committed

Bug description:
  [Impact]
  Using IPv4-specific APIs during NIC setup based on iBFT information, regardless of the IP version, results in the following error in IPv6-only environments:

  Setting up software interface ens300f0np0
  iscsistart: Invalid or missing ipaddr in fw entry
  Setting up software interface ens300f0np0 failed

  [Fix]
  Upstream has a patch to resolve this issue.

  commit 72c2b97c19a2d0710b38802d50813feb682278f7
  Author:     yukariatlas <49406051+yukariatlas at users.noreply.github.com>
  Date: Fri Dec 27 11:03:43 2024 -0800

      IPv6 support for iBFT iSCSI boot (#493)

      * Avoid reassigning a char pointer variable to a newly allocated
  string

      Introduce two separate variables to clearly distinguish their
  usage.

      Signed-off-by: Chengen Du <chengen.du at canonical.com>

      * IPv6 support for iBFT iSCSI boot

      Use IPv4-specific APIs during NIC setup based on iBFT information,
      regardless of the IP version, which leads to the following error
      in IPv6-only environments:

      Setting up software interface ens300f0np0
      iscsistart: Invalid or missing ipaddr in fw entry
      Setting up software interface ens300f0np0 failed

      To address this, the process now determines the IP version first
      and calls the appropriate functions to handle NIC setup.

      Signed-off-by: Chengen Du <chengen.du at canonical.com>

      ---------

      Signed-off-by: Chengen Du <chengen.du at canonical.com>

  [Test Plan]
  1. Set up a machine with an iSCSI backend in an IPv6-only environment.  
  2. Power on the machine and verify that the following error does not occur:  
     Setting up software interface ens300f0np0  
     iscsistart: Invalid or missing ipaddr in fw entry  
     Setting up software interface ens300f0np0 failed  
  3. Ensure that the machine can successfully boot via iSCSI in an IPv4 environment.

  [Where problems could occur]
  The fix primarily adds IPv6 support for iBFT iSCSI boot and should not impact the IPv4 scenario. However, if any regressions occur, the iBFT iSCSI boot mechanism may be affected, potentially preventing the machine from booting via iSCSI.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/2097808/+subscriptions