[Bug 366543] [NEW] jpilot inserts bogus text in vCard export

[David Gibson]

Public bug reported:

Binary package hint: jpilot

The version of jpilot in Ubuntu 9.04 (that is jpilot 1.6.0-1)
incorrectly exports to vcard format.

When exporting addresses to vcard format, jpilot it inserts an extra copy of the category information in front of
the FN: tag, meaning the vcf output is invalid.

i.e. it produces:
        BEGIN:VCARD
        VERSION:3.0
        PRODID:-//Judd Montgomery//NONSGML J-Pilot 1.6.0//EN
        UID:palm-addressbook-003430dd-000003e8-David Gibson at mulberryst
        CATEGORIES:Business
-->   "Business",FN:ABN Amro Morgans
        N:ABN Amro Morgans
        ORG:ABN Amro Morgans
        TEL;TYPE=work,pref:6232 4999
        ADR:;;Level 1\, 25 Napier Close\, Deakin;;;;


        END:VCARD

When it should produce this:
        BEGIN:VCARD
        VERSION:3.0
        PRODID:-//Judd Montgomery//NONSGML J-Pilot 1.6.0//EN
        UID:palm-addressbook-003430dd-000003e8-David Gibson at mulberryst
        CATEGORIES:Business
-->   FN:ABN Amro Morgans
        N:ABN Amro Morgans
        ORG:ABN Amro Morgans
        TEL;TYPE=work,pref:6232 4999
        ADR:;;Level 1\, 25 Napier Close\, Deakin;;;;


        END:VCARD

I've located the source of the problem, it's in address_gui.c:
         utf = charset_p2newj(contact_app_info.category.name[mcont->attrib & 0x0F], 16, char_set);
         str_to_vcard_str(csv_text, sizeof(csv_text), utf);
         fprintf(out, "CATEGORIES:%s%s", csv_text, CRLF);
         fprintf(out, "\"%s\",", utf);
         g_free(utf);

The last fprintf() line is bogus and should be removed.  This problem is
also in jpilot's upstream CVS.

** Affects: jpilot (Ubuntu)
     Importance: Undecided
         Status: New

-- 
jpilot inserts bogus text in vCard export
https://bugs.launchpad.net/bugs/366543
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs