[Bug 513688] [NEW] FTBFS in Lucid (2 clause open(2) with O_CREAT)

[Jon Dowland]

Public bug reported:

Binary package hint: archfs

Looking at http://launchpadlibrarian.net/35890741/buildlog_ubuntu-lucid-
amd64.archfs_0.5.4-1_FAILEDTOBUILD.txt.gz

problem appears to be the use of the 2 clause version of open(2) with
O_CREAT unmasked in the second argument, which is invalid. Fix is to add
a third argument with a mode. This patch should fix it (unsure: my local
gcc doesn't fail with the 2 clause version):

commit 02c13984d720ddfe6a5fe654d8e0e8242884276e
Author: Jon Dowland <jmtd at debian.org>
Date:   Thu Jan 28 09:31:44 2010 +0000

    use 3-clause open(2) with O_CREAT

diff --git a/layout/support.c b/layout/support.c
index a1c9f23..80fd79e 100644
--- a/layout/support.c
+++ b/layout/support.c
@@ -71,7 +71,7 @@ int unzip_revs(char *path){
                 gstrdel(extension);
                if (gmstrcpy(&mirror, tmp_file, "/", entry->d_name, 0) == -1)
                        continue;
-               if ((descriptor = open(mirror, O_WRONLY | O_CREAT)) == -1)
+               if ((descriptor = open(mirror, O_WRONLY | O_CREAT, S_IRWXU)) == 
                        continue;
                if (close(descriptor) == -1)
                        continue;

I will be applying this patch to the Debian package at some point in the
near future.

** Affects: archfs (Ubuntu)
     Importance: Undecided
         Status: New

-- 
FTBFS in Lucid (2 clause open(2) with O_CREAT)
https://bugs.launchpad.net/bugs/513688
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs