[Merge] lp:~xnox/upstart/fix-qemu-test into lp:upstart

Dmitrijs Ledkovs launchpad at surgut.co.uk
Mon Dec 3 09:53:23 UTC 2012


Dmitrijs Ledkovs has proposed merging lp:~xnox/upstart/fix-qemu-test into lp:upstart.

Requested reviews:
  James Hunt (jamesodhunt)

For more details, see:
https://code.launchpad.net/~xnox/upstart/fix-qemu-test/+merge/137512

Originally the race was noticed in the Ubuntu Cloud image booted in qemu as part of autopkgtest runner.

Waiting for the pid of the test job, makes this race evident on my local host as well.

At first, I have tried to do the log checks in the pid greater than zero branch, but at that time the log was not written yet, hence I moved it later @ the test clean up. I am not sure how correct this is.

With this change & stgrabers initctl2dot merge fix, the autopkgtest pass as run in the jenkins environment.

-
v2 Applied review comments.
-- 
https://code.launchpad.net/~xnox/upstart/fix-qemu-test/+merge/137512
Your team Upstart Reviewers is subscribed to branch lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 728 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20121203/079f399b/attachment.diff>


More information about the upstart-devel mailing list