[Merge] lp:~stgraber/upstart/upstart-shell-paths into lp:upstart

[Stéphane Graber]

Stéphane Graber has proposed merging lp:~stgraber/upstart/upstart-shell-paths into lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)

For more details, see:
https://code.launchpad.net/~stgraber/upstart/upstart-shell-paths/+merge/140175

We recently noticed a bunch of upstart build failures caused by
test_job_process reporting that pWD=/ was added to the environment which
wasn't quite expected.

This was eventually tracked down to upstart calling the command through a
shell if any of the usual shell special characters are found (like ~ in this
case).

This branch does two things:
 - Changes job_process.c slightly to explicitly set ->script = TRUE when
   upstart decides that the command needs to be run under a shell.
 - Updates the tests to check for the post-run value of ->script and allow
   for PWD=/ in such case.

PWD will always be / if present as the shell itself is provided without any
environment and so can't inherit PWD.
-- 
https://code.launchpad.net/~stgraber/upstart/upstart-shell-paths/+merge/140175
Your team Upstart Reviewers is requested to review the proposed merge of lp:~stgraber/upstart/upstart-shell-paths into lp:upstart.