[Merge] lp:~stgraber/upstart/upstart-initctl2dot-python3 into lp:upstart

[Stéphane Graber]

Stéphane Graber has proposed merging lp:~stgraber/upstart/upstart-initctl2dot-python3 into lp:upstart.

Requested reviews:
  Barry Warsaw (barry)
  Upstart Reviewers (upstart-reviewers)
Related bugs:
  Bug #1058029 in upstart (Ubuntu): "Port initctl2dot to Python 3"
  https://bugs.launchpad.net/ubuntu/+source/upstart/+bug/1058029

For more details, see:
https://code.launchpad.net/~stgraber/upstart/upstart-initctl2dot-python3/+merge/136721

This branch updates initctl2dot to work with both python2 and python3.
The tested versions were python2.7 and python3.3.

The main changes are:
 - Fixing a bunch of errors spotted by pyflakes.
 - Added universal_newlines=True to the subproces call
 - Stop using string.split, instead split use <str>.split
 - Re-indent the code, split lines, ... to please pep8

I also fixed a small bug where if a job name contained a dot, the .dot file
would be invalid. I'm simply replacing dots by underscores which appears to do
the trick.

The code should now be PEP-8 clean and the output appears to work as expected
when fed to graphviz.
-- 
https://code.launchpad.net/~stgraber/upstart/upstart-initctl2dot-python3/+merge/136721
Your team Upstart Reviewers is requested to review the proposed merge of lp:~stgraber/upstart/upstart-initctl2dot-python3 into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 30593 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20121128/bb691beb/attachment-0001.diff>