[Merge] lp:~jamesodhunt/upstart/set-env--global-apply-to-running-jobs into lp:upstart
James Hunt
james.hunt at canonical.com
Fri Feb 15 16:38:21 UTC 2013
James Hunt has proposed merging lp:~jamesodhunt/upstart/set-env--global-apply-to-running-jobs into lp:upstart.
Requested reviews:
Upstart Reviewers (upstart-reviewers)
For more details, see:
https://code.launchpad.net/~jamesodhunt/upstart/set-env--global-apply-to-running-jobs/+merge/148754
This branch makes the '--global' option for the initctl commands 'set-env' and 'unset-env' (but not 'reset-env') apply not just to all newly-started jobs (by modifying the global job environment table), but also to all *running* job objects environment tables. Note that this is not changing a running job processes *process environment*, it's changing a running job processes *Upstart environment table*.
This is a potentially confusing thing for a job to do, but is required for jobs which start early and wish to change the global environment from for example a pre-start stanza and have that change available to:
- all newly-started jobs.
- all subsequent job processes that the job which initiated the change runs.
As it could confuse, I've added a warning in the initctl man page on the use of --global for these commands.
Note that the branch somewhat arbitrarily does not apply such behaviour for the 'reset-env' command as yanking a jobs carefully prepared environment between job processes is just asking for trouble. If really desired, a similar outcome can be effected using 'unset-env --global'.
--
https://code.launchpad.net/~jamesodhunt/upstart/set-env--global-apply-to-running-jobs/+merge/148754
Your team Upstart Reviewers is requested to review the proposed merge of lp:~jamesodhunt/upstart/set-env--global-apply-to-running-jobs into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4925 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20130215/81bbf0f3/attachment.diff>
More information about the upstart-devel
mailing list