[Merge] lp:~cameronnemo/upstart/ipv6 into lp:upstart

[James Hunt]

Review: Needs Fixing

Hi Cameron,

Thanks to you and Kai for undertaking this new feature!

A few comments:

* extra/upstart-socket-bridge.c:
  - epoll_watcher():
    - 'break' has been lost from end of the AF_INET block.
    - buffer should not use nih_local (as that is only for allocated storage) and should really be at the
      top of the 'for' block.
    - AF_INET6 block missing a 'break' at the end.
  - job_add_socket(): '! strcmp (*env, "ADDR")' needs to be updated for IPv6 (using inet_pton() rather than
    inet_aton() maybe?).

I tried testing this using the new IPv6 example from socket-event.7, but I think the last comment above is causing the job to be rejected.


-- 
https://code.launchpad.net/~cameronnemo/upstart/ipv6/+merge/204599
Your team Upstart Reviewers is subscribed to branch lp:upstart.