[apparmor] parser line number reporting
Kees Cook
kees at ubuntu.com
Fri Jun 25 17:17:35 BST 2010
On Fri, Jun 25, 2010 at 04:09:07AM -0700, Steve Beattie wrote:
> Haha, I shouldn't try to write patches late at night. Really
> attaching the patch this time.
Oh good, I thought I was going crazy again. :)
> > (As an aside, Kees, I'm glad you added testcases with the lineno
> > commit, though the infrastructure needs to be improved to make adding
> > additional testcases easier.)
Yeah, there are at least 3 testsuites in the parser tree, and I'm to blame
for 2 of them. :P However, the original parser testsuite wasn't really
designed to do the testing needed for the other two suites. Gaaar.
> #include/.*\r?\n { /* include */
> PDEBUG("Matched #include\n");
> - current_lineno++;
> BEGIN(INCLUDE);
THERE it is. Thank you for finding this. When I was testing this, I just
felt like something was missing, but my eyes had already crossed too hard
to see it.
ACK.
--
Kees Cook
Ubuntu Security Team
More information about the AppArmor
mailing list