[apparmor] parser line number reporting

Steve Beattie sbeattie at ubuntu.com
Fri Jun 25 21:06:29 BST 2010


On Fri, Jun 25, 2010 at 04:09:07AM -0700, Steve Beattie wrote:
> On Fri, Jun 25, 2010 at 04:05:44AM -0700, Steve Beattie wrote:
> > On Mon, Jun 21, 2010 at 01:32:54PM -0700, Kees Cook wrote:
> > > Nominations from me:
> > > 
> > > r1413 (correct line number and filename tracking for error messages)
> > 
> > I don't think this should be accepted without the additional attached
> > patch, as there are some subtle errors in the line counting happening.
> > See the attached patch's description.
> 
> Haha, I shouldn't try to write patches late at night. Really
> attaching the patch this time.
> 
> > It's submitted for review for both trunk and for 2.5.1 as a condition
> > for acceptance of r1413.
> > 
> > (As an aside, Kees, I'm glad you added testcases with the lineno
> > commit, though the infrastructure needs to be improved to make adding
> > additional testcases easier.)

Committed to trunk in r1418 and pulled along with r1413 for the 2.5.1
nominations branch. Thanks!

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/apparmor/attachments/20100625/a36ddd63/attachment.pgp 


More information about the AppArmor mailing list